matter-labs / matter-labs/zksync-protocol

`tx_number_in_block` width differs between runtime (`u16`) and circuit state (`u32`)

Open
#219 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
22
Forks
21
Avg merge
12h 46m
Merged PRs (30d)
2

Description

The runtime and circuit use different widths for `tx_number_in_block`.

Runtime side:
- `LogQuery.tx_number_in_block` is `u16` in `crates/zk_evm_abstractions/src/queries.rs`
- VM increments it with wrapping semantics in `crates/zk_evm/src/vm_state/helpers.rs`

Circuit side:
- VM state stores it as `UInt32` in `crates/zkevm_circuits/src/base_structures/vm_state/mod.rs`
- increment logic uses `UInt32` arithmetic in `crates/zkevm_circuits/src/main_vm/opcodes/context.rs`

Suggested fix:
- either enforce a hard `< 2^16` bound in the circuit and witness path
- or widen the runtime representation and document the intended max value explicitly

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the runtime definitions and increment logic in crates/zk_evm_abstractions/src/queries.rs and crates/zk_evm/src/vm_state/helpers.rs with the circuit state and opcode logic in crates/zkevm_circuits/src/base_structures/vm_state/mod.rs and crates/zkevm_circuits/src/main_vm/opcodes/context.rs. Determine the intended maximum and representation, then update the runtime, circuit, witness path, or documentation so the width and overflow behavior are consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.