matter-labs / matter-labs/zksync-cli
Bridge deposit broken on new networks
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 168
- Forks
- 99
- PR merge metrics
- No merged PRs in 30d
Description
๐ Bug Report for zksync-cli
๐ Description
It appears that bridge deposit does not necessarily work for new networks with custom base token.
๐ Reproduction Steps
- Have a network with custom base token deployed with protocol v28
- Execute
zksync-cli bridge deposit --token=BASE_TOKEN --rpc=$L2_RPC --l1-rpc=https://sepolia.drpc.org/
- Error
Recipient address on L2 XXXXX
โ There was an error while depositing funds:
โ execution reverted (payload={ "id": 6, "jsonrpc": "2.0", "method": "eth_call", "params": [ { "data": "0x95d89b41", "to": "0x000000000000000000000000000000000000800a" }, "latest" ] }, error={ "code": 3, "data": "0x", "message": "execution reverted" }, code=3, version=6.14.3)
๐ค Expected Behavior
zksync-cli should not call symbol() (0x95d89b41) on 0x000000000000000000000000000000000000800a as its no longer there.
๐ฏ Current Behavior
zksync-cli errors due to revert on call to non-existing 0x95d89b41 selector on base token contract address
๐ฅ๏ธ Environment
- Package version:
zksync-cli --version
1.13.0
๐ Additional Context
Reporting for partner
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up โ it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing zksync-cli bridge deposit --token=BASE_TOKEN against a protocol v28 network with a custom base token, then trace the bridge deposit entry point and the code making the symbol() call at 0x000000000000000000000000000000000000800a. Done means deposits no longer fail when that selector is unavailable; verify the command completes successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100