matter-labs / matter-labs/zksync-cli

Bridge deposit broken on new networks

Open
#193 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
168
Forks
99
PR merge metrics
No merged PRs in 30d

Description

๐Ÿ› Bug Report for zksync-cli
๐Ÿ“ Description

It appears that bridge deposit does not necessarily work for new networks with custom base token.

๐Ÿ”„ Reproduction Steps
  1. Have a network with custom base token deployed with protocol v28
  2. Execute
zksync-cli bridge deposit --token=BASE_TOKEN --rpc=$L2_RPC --l1-rpc=https://sepolia.drpc.org/
  1. Error
Recipient address on L2 XXXXX
โ“˜ There was an error while depositing funds:
โ“˜ execution reverted (payload={ "id": 6, "jsonrpc": "2.0", "method": "eth_call", "params": [ { "data": "0x95d89b41", "to": "0x000000000000000000000000000000000000800a" }, "latest" ] }, error={ "code": 3, "data": "0x", "message": "execution reverted" }, code=3, version=6.14.3)
๐Ÿค” Expected Behavior

zksync-cli should not call symbol() (0x95d89b41) on 0x000000000000000000000000000000000000800a as its no longer there.

๐Ÿ˜ฏ Current Behavior

zksync-cli errors due to revert on call to non-existing 0x95d89b41 selector on base token contract address

๐Ÿ–ฅ๏ธ Environment
  • Package version:
zksync-cli --version
1.13.0
๐Ÿ“‹ Additional Context

Reporting for partner

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up โ€” it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing zksync-cli bridge deposit --token=BASE_TOKEN against a protocol v28 network with a custom base token, then trace the bridge deposit entry point and the code making the symbol() call at 0x000000000000000000000000000000000000800a. Done means deposits no longer fail when that selector is unavailable; verify the command completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.