matter-labs / matter-labs/block-explorer
Native Token definition is incorrect
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 139
- Forks
- 145
- Avg merge
- 8h 3m
- Merged PRs (30d)
- 3
Description
### 🐛 Bug Report
#### 📝 Description
Native Tokens were implemented as part of v27 release. We have a definition of "native token" in Explorer that does not correlate to the definition of this Native Token.
For example on the Tokens page, a native token label is defined if the L1 address is not set for the token.
To check if a token is a Native Token, the originChainId needs to be checked via the Native Token Vault contract. If the originChainId matches the network's id, then it is a native token. It can still be a Native Token with an L1 address defined.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Tokens page logic that assigns the native token label, then trace how the Native Token Vault exposes originChainId for the network. The change is complete when the label follows the originChainId match and remains correct for tokens that have an L1 address defined; no specific test file is named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100