matteolucchini1 / matteolucchini1/BHJet

Improve cyclosynchrotron seed field normalization

Open
#25 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement low priority
Dominant language
C++
Stars
18
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Currently Urad takes uses a dodgy pi r^2 factor to renormalize from luminosity to energy density. Instead, change to consider different geometries (and check with re-normalization to find flux at the end!!!!)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Urad calculation responsible for converting luminosity to energy density and review how the pi r^2 factor is applied. Clarify which geometries must be supported, then check whether re-normalization recovers the expected flux at the end.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.