mattdesl / mattdesl/workshop-web-audio
polygone always 3 sides in 15-tone-mp3-effects.js
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 202
- Forks
- 58
- PR merge metrics
- No merged PRs in 30d
Description
The polygon function has the number of sides hard coded.
function polygon(x, y, radius, sides = 3, angle = 0) {
And should be: function polygon(x, y, radius, sides, angle = 0) {
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/js/15-tone-mp3-effects.js and inspect the polygon function around line 83. Confirm that the sides argument is passed through rather than defaulting to 3, then verify the affected tone and MP3 effect behavior manually.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100