mattdesl / mattdesl/spawn-npm-install
Consider listening for the error event
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 19
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
It's possible for this module to throw an error if no one is listening for the `error` event on the `proc` object returned from `spawn`.
You could argue that this is up to the user, but since you allow to user to give an optional callback I'd say that error should be redirected there.
Alternatively this should probably be documented in the README.md.
I'll happily make a PR in either case.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the module's spawn call and the README.md, focusing on the proc object returned from spawn and the optional callback mentioned in the issue. Decide whether the callback should receive the error or the behavior should be documented; done means the chosen behavior is covered and no error-handling ambiguity remains.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100