mattdesl / mattdesl/keyframes

Non lerpable values

Open
#2 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
34
Forks
6
PR merge metrics
No merged PRs in 30d

Description

I know we discussed this once already. But I forget the answer and figure it's better to document it here.

What if you made it so that non lerpable values are simply returned.

Let's say you did this:

keyframes.add({ time: 0, value: 'a' })
keyframes.add({ time: 1.5, value: 'b' })
keyframes.add({ time: 4, value: 'c' })

var value = keyframes.value( 1 ); // value == 'a'

This would be very handy if value is a function.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start at the keyframes.value entry point and trace how values between keyframes are interpolated. Done means non-lerpable values, including functions, return the preceding keyframe value as shown in the JavaScript example, with regression coverage if the project has an existing test location.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.