matryer / matryer/vice

context.Context friendly API

Open
#59 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.5k
Forks
76
PR merge metrics
No merged PRs in 30d

Description

https://github.com/matryer/vice/blob/660007f4486b289078664b182d1ecd2a22b29b02/transport.go#L24

Done() in context.Context returns a `<-chan struct{}`, which is not compatible with vice.Transport.

```
*Transport does not implement vice.Transport (wrong type for Done method)
have Done() <-chan struct {}
want Done() chan struct {}
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at transport.go line 24, the linked definition of vice.Transport, and compare it with context.Context's Done method. Confirm the intended compatible API from the reported compiler error, then run the repository's Go tests or build to verify that the interface mismatch is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.