matryer / matryer/try

Package is not stateless, not concurrency-safe

Open
#3 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
366
Forks
47
PR merge metrics
No merged PRs in 30d

Description

It looks like it is not possible to use this package in several places with different values for MaxRetries. Also it is not concurrency safe to mutate this value if package is used from multiple goroutines - e.g. one might be setting MaxRetries value and another one will be reading without any synchronization.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are identified in the issue. Start by locating the definition and all reads and writes of MaxRetries, then review how package state is shared across goroutines. Done means separate uses can have different retry values and concurrent access is safe, with tests covering both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.