matrix-org / matrix-org/waterfall
Find the cause and fix the `rtcp: packet too short` error
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 105
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
Whenever we're writing the RTCP packet, it oftentimes fails with this error. It's not clear what exactly causes this error (since we do not construct RTCP packets, but get them from Pion, [then we only overwrite them](https://github.com/matrix-org/waterfall/pull/88).
**UPD.** Apparently, these are FIR requests (we probably need to overwrite several fields there, not only the `MediaSSRC`).
Current workaround is that we "convert" all FIRs into PLIs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the RTCP packet-writing path and trace how Pion-provided FIR requests are overwritten, especially the MediaSSRC field. Compare the current handling with the workaround that converts FIRs to PLIs; done means valid FIR packets no longer fail with `rtcp: packet too short` without relying on that workaround.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100