matrix-org / matrix-org/waterfall

Implement MID-based signaling

Open
#72 0 comments 0 reactions 1 assignee View on GitHub

@daniel-abramov is already working on this.

Since Dec 12, 2022.

T-Enhancement T-Task
Dominant language
Go
Stars
105
Forks
5
PR merge metrics
No merged PRs in 30d

Description

See the rationale in a discussion here: https://github.com/vector-im/voip-internal/discussions/79

  • Essentially, the trackIDs identify a track and they are unique, but they are not guaranteed to match on both sides.
  • streamIDs identify a stream ("container" of tracks) and are not unique, but they are guaranteed to match on both sides.
  • mids identify a single transceiver/track and are not unique, but they are guaranteed to match on both sides.

Since we work on a track level and the trackID is not a sustainable option, we'll have to use mid based signaling. But since mids are not unique on their own, we'll have to use a combination of mid and some participant identifier (in our case deviceID). Then we would need to group mids that belong to a stream.

Use https://github.com/matrix-org/waterfall/pull/12/files as a reference on how it might have been implemented.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.