matrix-org / matrix-org/waterfall
Introduce a backpressure when sending peer messages to the conference
@daniel-abramov is already working on this.
Since Feb 1, 2023.
- Dominant language
- Go
- Stars
- 105
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
Currently, we use buffered channels with quite a larger buffer when we're sending messages from the peer to the conference to mutate the state of a conference. We do the same when we send incoming To-Device messages to the conference.
These queues don't seem to be very useful in most cases. It seems it's OK to let the senders block if the conference can't keep up with the messages as it would introduce a natural backpressure mechanism (i.e. it does not make sense to fill up the queue with the messages that must not even be necessary). It seems to play better with an idiomatic Go.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.