matrix-org / matrix-org/thirdroom

Script with error prevent world from loading

Open
#619 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
647
Forks
70
PR merge metrics
No merged PRs in 30d

Description

If we save script with error it breaks the world loading process without giving option to rollback script changes. Right now only way to make world loading work after that is to re-upload script from world settings.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure: save a script with an error, then try loading the world and compare it with the world settings re-upload flow. Trace the script save and world-loading entry points to determine where a rollback option belongs; done means an erroneous saved script no longer prevents loading and users can recover without re-uploading it.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.