matrix-org / matrix-org/thirdroom

Use proper RGBM Encoding for reflection probes / skybox

Open
#396 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Content Engine
Dominant language
C
Stars
647
Forks
70
PR merge metrics
No merged PRs in 30d

Description

The Unity exporter and thirdroom's shader patches aren't properly handing RGBM cubemaps. This should be fixed ASAP as it's a breaking change.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Unity exporter and Thirdroom shader patches, then trace how reflection probes and skyboxes handle RGBM cubemaps. Reproduce the incorrect encoding behavior and compare both paths; done means the exporter and shader patches properly handle RGBM cubemaps without breaking existing rendering.

Written by the indexing model from the issue text.

Assessment

Tech stack
three.js, unity
Domain
computer-graphics, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.