matrix-org / matrix-org/sytest

31sync/09archived: "Newly left rooms appear in the leave section of gapped sync": possible bug in not creating the filter properly

Open
#1,309 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Perl
Stars
81
Forks
63
Avg merge
1h 47m
Merged PRs (30d)
1

Description

https://github.com/matrix-org/sytest/blob/3871417ce99a406dda52e99dfeac32a222226b46/tests/31sync/09archived.pl#L185-L189

My IDE highlighted the $filter here as "not used";

image

It is possible that this might have caused this test to not run correctly for 7 years (since 2015)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect tests/31sync/09archived.pl around lines 185-189, focusing on the IDE-reported unused $filter. Run the relevant archived-room gapped-sync test and verify whether the filter is created and used as intended; done means the test exercises the reported behavior correctly and passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.