matrix-org / matrix-org/sytest
`31room-messages.pl` lazy-loading test is probably incorrect/too specific to one bug
Nobody has claimed this yet.
- Dominant language
- Perl
- Stars
- 81
- Forks
- 63
- Avg merge
- 1h 47m
- Merged PRs (30d)
- 1
Description
Currently it is testing lazy-loading with a single user, while only asserting for that single user in a `/messages` backwards-pagination request (in `state`).
In other words, this is testing for a single bug, while not testing if lazy-loading is working correctly at all by including other users in that test, and testing if those do/dont exist in the `state` included.
Nowhere else in sytest is `/messages` properly tested for lazy-loading, this is the only spot, and it's only checking for this one specific bug, so I question how useful that is.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with 31room-messages.pl and its /messages backwards-pagination case in state. Run the existing lazy-loading test, then extend coverage to multiple users and verify which users do and do not appear in the included state; done means the test checks lazy-loading behavior beyond the single reported bug.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- perl
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100