matrix-org / matrix-org/sytest
Test "GET /rooms/:room_id/joined_members fetches my membership" expects display_name and avatar_url to be present
Open
Nobody has claimed this yet.
- Dominant language
- Perl
- Stars
- 81
- Forks
- 63
- Avg merge
- 1h 47m
- Merged PRs (30d)
- 1
Description
GET /rooms/:room_id/joined_members fetches my membership says
# We always have these keys even if they're undef
assert_json_keys( $myself, qw( display_name avatar_url ));
Synapse seems to return null if they're not set. The specification isn't clear if those fields are optional or not. It doesn't say required, so I assume they're optional. So I think Sytest should allow either them non-existing or being null (or the expected value).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Sytest covering GET /rooms/:room_id/joined_members fetches my membership and inspect the assertion for display_name and avatar_url. Done means the test accepts either an absent field, a null value, or the expected value when Synapse returns the membership.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- perl
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100