matrix-org / matrix-org/sytest

01request-encoding is incorrect compared to the spec

Open
#1,024 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Perl
Stars
81
Forks
63
Avg merge
1h 47m
Merged PRs (30d)
1

Description

[request-encoding](https://github.com/matrix-org/sytest/blob/c75ff0449b5b62bdebfdb9024170988b519628d9/tests/10apidoc/01request-encoding.pl) is testing if a homeserver accepts Unicode character `0x81` in the JSON request body, however, this is allowed according to the [canonical JSON grammar](https://spec.matrix.org/unstable/appendices/#grammar) grammar, because `%x5D-10FFFF` falls into the allowed unescaped characters section, which `0x81` is a part of.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/10apidoc/01request-encoding.pl and compare its handling of Unicode character 0x81 with the canonical JSON grammar in the linked Matrix specification. Update the test so its expected behavior matches the grammar, then run the relevant sytest request-encoding test to confirm it passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.