matrix-org / matrix-org/rust-synapse-compress-state
[Manual compressor] Compressor keeps emitting empty transactions
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 173
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
Emitted SQL contains huge blocks of empty transactions:
-- ...
COMMIT;BEGIN;
COMMIT;BEGIN;
COMMIT;BEGIN;
COMMIT;BEGIN;
-- ...
Especially annoying when the generated SQL script only contains empty transactions and no other content:
BEGIN;
COMMIT;BEGIN;
COMMIT;BEGIN;
COMMIT;
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the manual compressor's transaction-emission entry point and reproduce the issue with input that produces no content. Trace how BEGIN and COMMIT are emitted for empty transactions. Done means generated SQL contains no empty transactions, including when the entire script has no other content; add or update a regression test if the project has coverage for this path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust, sql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 48/100