matrix-org / matrix-org/mscbot-python
FCP can be started again after one had successfully completed
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
For instance, after an FCP merge is successful and the proposal is accepted, if a user edits the latest FCP proposal comment and there's enough votes, mscbot will start FCP again. ([Example](https://github.com/matrix-org/matrix-spec-proposals/pull/1767#issuecomment-1420425298)).
A fix here would be to ignore edits to FCP comments if the `proposed-final-comment-period` label is not present.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the FCP comment edit handling in mscbot and inspect how the proposed-final-comment-period label is checked. Reproduce the case where a completed FCP comment is edited, then verify that the edit does not start another FCP when the label is absent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100