matrix-org / matrix-org/mjolnir
!mjolnir kick *: Don't remove the bot itself
Open
- Dominant language
- TypeScript
- Stars
- 445
- Forks
- 75
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 3
Description
Removing all users via `!mjolnir kick *` can be useful for closing a channel. However, mjolnir will remove itself before having removed all other users and globs are not sophisticated enough to avoid this.
I would suggest that `!mjolnir kick` should never remove the bot itself.
Contributor guide
Research direction
Start by locating the implementation of the `!mjolnir kick` command and its `*` glob handling. Verify that a kick-all operation skips the bot while still removing other users, and test the command behavior with a channel containing multiple users.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100