matrix-org / matrix-org/mjolnir

Add a retry queue to requests

Open
#560 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
445
Forks
75
Avg merge
2d 44m
Merged PRs (30d)
3

Description

Quite often we'll get an error in our room saying
````
1 errors updating protected rooms!

[Room Name] - Error during MatrixClient request GET [URL] - 503 Service Temporarily Unavailable -- 503 Service Temporarily Unavailable
503 Service Temporarily Unavailable
nginx
```

Mjolnir would be great if it could just keep trying since as it says this is a temporary service issue. The retry queue should be incremental of course, try after 5 seconds, then 15, 30, 60, 180, 600. Then if after all those tries it still cannot get the request in, send the error message to the channel.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the request path that reports MatrixClient errors and review how protected-room updates handle failures. Done means temporary failures are retried at 5, 15, 30, 60, 180, and 600 seconds, with the error sent to the channel only after all attempts fail.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.