matrix-org / matrix-org/mjolnir

Access around Mjolnir owners doesn't match up with communities.

Open
#420 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-Appservice O-Uncommon S-Major X-Needs-Investigation
Dominant language
TypeScript
Stars
445
Forks
75
Avg merge
2d 44m
Merged PRs (30d)
3

Description

Access to a particular mjolnir (whether that mjolnir is still run) is managed by the owner.
If we remove an owner's access to a mjolnir, we also end up closing out anyone else in that mjolnir's management room from using the mjolnir.

>What I mean is that we can have the following:

>1.User A is in good standing.
>2. User A creates a Mjölnir.
>3. User A steps down, letting user B be the de facto owner of this Mjölnir.
>4. User A becomes an obnoxious troll and gets kicked out from the server.
>5. We remove A's authorization to generate Mjölniren (I think I'm going to keep that plural :) ).
>6. Any Mjölnir of A gets closed.
>7. B loses a Mjölnir.
>The only reason I can think of for indexing Mjölniren by creator is to do 6, no?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by tracing how Mjölnir ownership, authorization removal, and management-room membership are represented, then inspect where creator-based indexing triggers closure. Done should preserve access for remaining managers while retaining the intended behavior for Mjölnir instances whose authorized owner is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authorization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.