matrix-org / matrix-org/mjolnir
We need to decide how to check that a mjolnir owner still has access to the appservice
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 445
- Forks
- 75
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 3
Description
Do we only check when the appservice is restarted? probably not.
Do we need to check each time they use the web api? probably.
Do we need to check each time they send a command to one of their mjolnirs? Probably.
We need to work out the API for these checks in a way that means programmers won't clumsily refactor them out, so it probably has to be implicit to every use of the mjolnir manager.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/appservice/MjolnirManager.ts#L154-L174 and trace how the manager is used by the web API and mjolnir commands. Determine when owner access must be checked and how the manager API should make those checks implicit; done means the check points and API behavior are decided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authorization, backend-api-design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100