matrix-org / matrix-org/mjolnir
Rename `mjolnir.protectedRoomsTracker` to `mjolnir.protectedRooms` and try make it private to mjolnir.
Open
Nobody has claimed this yet.
T-Task
- Dominant language
- TypeScript
- Stars
- 445
- Forks
- 75
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 3
Description
Follow up from https://github.com/matrix-org/mjolnir/pull/385
It's confusing and is actually the source of which rooms are protected for mjolnir.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the context from pull request 385, then search the repository for mjolnir.protectedRoomsTracker and inspect how the protected-room source is accessed. Rename it to mjolnir.protectedRooms and make it private to mjolnir where possible; done means all references use the new name and external access is restricted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100