matrix-org / matrix-org/mjolnir

Have protectedRooms accept normal aliases/roomIDs

Open
#295 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
445
Forks
75
Avg merge
2d 44m
Merged PRs (30d)
3

Description

It feels a bit weird to deal with matrix.to URLs and matrix room IDs/aliases at the same time in a config. (`protectedRooms` vs `managementRoom`)

Shouldn't we convert it all to using IDs/aliases, but also add a function that will convert matrix.to URLs and matrix URIs to them, for backwards compatibility?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how protectedRooms and managementRoom are parsed and compared in the configuration path. Define the accepted Matrix room IDs, aliases, matrix.to URLs, and Matrix URIs, then verify that old URL and URI configurations normalize consistently with IDs and aliases. Done means both configuration styles work without changing existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.