matrix-org / matrix-org/mjolnir
Mjolnir reacts with a tick to indicate command success when it actually had a failure (powerlevel command)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 445
- Forks
- 75
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 3
Description
Describe the bug
When changing the permissions of a user via the powerlevel command, if Mjolnir does not have the power level in the target room to be able to change the room power levels, Mjolnir will fail and send a message describing the failure but a reaction will still be added to the command event as though it were a success.
Expected behaviour
A cross should be added instead and we should check that other commands are also not affected.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the powerlevel command handler and trace how command success and failure reactions are selected. Reproduce the insufficient-permission case, then inspect the handling of other commands for the same behavior. Done means failures receive a cross while successful commands retain their success reaction, with relevant existing tests passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100