matrix-org / matrix-org/matrix.to

Enable "ask every time" by default

Open
#294 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.4k
Forks
318
PR merge metrics
No merged PRs in 30d

Description

Requested Change

Either enable "ask every time" by default or replace it with its opposite.

Reasoning

Many users may just click on continue without realizing that the selected Matrix server will receive all preview requests in the future (or until the). If that first one is not their own home server, this may result in an unnecessary leak of user data. (e.g. first I preview a user on malicious.matrix.example and accept previews there (more for this one case) and then preview users which are on other.matrix.example, the malicious one will not only know my IP but also know which user I wanted to write with).

Selecting this preview server should be an action which requires explicit agreement with knowing the consequences and not just "yeah, I want to preview this users image of course by asking his home server, why do you even ask".
This is not just my opinion but a requirement of the GDPR in the EU.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the preview-server selection and consent flow, then clarify whether the intended outcome is enabling “ask every time” by default or removing its opposite; done means the privacy-sensitive choice requires explicit agreement before future preview requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.