matrix-org / matrix-org/matrix.org

Improve the lightbox on try-matrix

Open
#3,344 0 comments 0 reactions 0 assignees View on GitHub
aesthetic help wanted
Dominant language
JavaScript
Stars
616
Forks
463
Avg merge
2d 3h
Merged PRs (30d)
19

Description

I noticed the "close" x in the lightbox is always top right of the screen, i.e. sometimes very far from the actual image or even over it's border. Could maybe improve the placement some time.
Screenshot_20260409-174408

Also the lightbox seems to make it into browsing history, so browser navigation after checking out all the lightboxes is pretty annoying.

_Originally posted by @HarHarLinks in https://github.com/matrix-org/matrix.org/pull/3239#pullrequestreview-4083602770_

Contributor guide

Open the contributing guide

Research direction

Start at the try-matrix lightbox implementation and inspect how the close control is positioned and how opening a lightbox affects browser history. Done means the close control stays near the image across layouts and browsing through lightboxes does not make back navigation unnecessarily revisit each lightbox.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.