matrix-org / matrix-org/matrix-viewer
Disable search form after submission
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 84
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
When there is a big delay between searches, it can be a bit awkward to interact with the form during the page-load and then have the new content pop in.
We can add a loading spinner to indicate that something is happening.
We want the disable/re-enable to be robust though to make sure we don't leave the user with a disabled form if they cancel the page-load.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the search form submission and page-load handling in the JavaScript frontend. Add a loading indication and ensure the form is disabled during loading but re-enabled when navigation is cancelled; verify both delayed searches and cancellation leave the form usable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100