matrix-org / matrix-org/matrix-synapse-ldap3

Module doesn't provide get_supported_login_types()

Open
#90 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

T-Defect
Dominant language
Python
Stars
139
Forks
47
PR merge metrics
No merged PRs in 30d

Description

Needed in https://github.com/matrix-org/synapse/blob/b2b86990705de8a099093ec141ad83e09f182034/synapse/handlers/auth.py#L95-L100

Otherwise, this doesn't appear to expose the correct flow for GET /login

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Synapse auth.py lines 95-100 and trace how the LDAP3 module supplies login-flow methods for GET /login. Compare the provider's exposed interface with the expected get_supported_login_types() method; done means the module exposes the correct login flow for that endpoint.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.