matrix-org / matrix-org/matrix-synapse-ldap3

Consider using ldaptor

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
139
Forks
47
PR merge metrics
No merged PRs in 30d

Description

The current ldap3 library isn't async by default, so we defer all blocking calls to a thread pool. This is not ideal.

ladptor is a twisted LDAP library that is async by default.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining how the current ldap3 integration defers blocking calls to a thread pool, then compare that approach with Twisted's ldaptor library. Done means the LDAP auth provider uses an async-by-default library without relying on the existing blocking-call workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
authentication, backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.