matrix-org / matrix-org/matrix-spec

Optional or required properties in data/api/client-server/definitions/event.yaml

Open
#828 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clarification
Dominant language
HTML
Stars
330
Forks
150
Avg merge
2h 21m
Merged PRs (30d)
3

Description

https://github.com/matrix-org/matrix-doc/blob/master/data/api/client-server/definitions/event.yaml

Some descriptions start with Optional., others don't. I would assume that the other fields are required. However, the event_id description contains if applicable, so it seems optional too.

This file has no required section to specify whether parameters are required or optional in a machine-readable way. No required section means all parameters are optional, but I don't think this is intentional, because data/event-schemas/schema/core-event-schema/event.yaml says all events must have content and type.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing data/api/client-server/definitions/event.yaml with data/event-schemas/schema/core-event-schema/event.yaml, especially the required fields and the event_id description. Determine which event properties are required or optional, then make the API definition express that consistently in machine-readable form and verify that the schema references agree.

Written by the indexing model from the issue text.

Assessment

Tech stack
yaml
Domain
api, documentation
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.