matrix-org / matrix-org/matrix-spec
if /send_join fails, you end up half-joined to a room
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 330
- Forks
- 150
- Avg merge
- 2h 21m
- Merged PRs (30d)
- 3
Description
if you send a `/send_join` request which times out (or your server/connection dies before you receive the response), then you end up in a situation where the remote server thinks you have joined the room, but the local server doesn't.
In synapse at least, that means that you end up with a bunch of `Ignoring PDU for unknown room_id: !room_id` warnings.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Matrix federation specification's /send_join flow and the timeout or lost-response case described in the issue. Reproduce or reason about the resulting mismatch between remote and local room membership, then document the expected behavior and verify that the unknown-room PDU warnings no longer follow from this failure.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend-api-design, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100