matrix-org / matrix-org/matrix-spec

Push notification rules should make sure to skip reply part of message

Open
#680 4 comments 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-Client-Server A-Push enhancement
Dominant language
HTML
Stars
330
Forks
150
Avg merge
2h 21m
Merged PRs (30d)
3

Description

ATM it's not specified and synapse sends notifications If someone was tagged inside message, that's being replied.
Example:
![Screenshot_20200818_061853](https://user-images.githubusercontent.com/7334549/90470373-9c3f9280-e11b-11ea-9e39-dc173d44da3e.png)
At the screenshot both messages tagged me, when only first should.

This is part of this related issue:
https://github.com/vector-im/element-web/issues/14943
Another part is matrix-org/matrix-spec-proposals#2735

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the current Matrix push notification rules and the related Element issue 14943 and Matrix proposal 2735 linked in the report. Determine how reply content is treated when evaluating mentions; done means the specification clearly excludes reply portions from triggering notifications while preserving direct tags in the main message.

Written by the indexing model from the issue text.

Assessment

Domain
backend-api-design, documentation
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.