matrix-org / matrix-org/matrix-spec

PUT /_matrix/client/r0/rooms/{roomId}/redact/{eventId}/{txnId} makes no sense

Open
#659 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-Client-Server wart
Dominant language
HTML
Stars
330
Forks
150
Avg merge
2h 21m
Merged PRs (30d)
3

Description

Sytest actually tests for `POST /_matrix/client/r0/rooms/{roomId}/redact/{eventId}` which makes more sense as there's no point having transaction IDs as the action is idempotent as it is. This means Synapse implements the POST form, and so will Dendrite. Why does this PUT form exist?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the Matrix client-server specification entry for PUT /_matrix/client/r0/rooms/{roomId}/redact/{eventId}/{txnId}, and compare it with Sytest's POST form and the Synapse and Dendrite behavior mentioned here. A decision is needed on whether the PUT form should be removed or clarified before the specification can be updated.

Written by the indexing model from the issue text.

Assessment

Domain
api, documentation
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.