matrix-org / matrix-org/matrix-spec
.m.rule.call should probably be an override rather than an underride rule
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 330
- Forks
- 150
- Avg merge
- 2h 21m
- Merged PRs (30d)
- 3
Description
https://matrix.org/docs/spec/client_server/r0.6.1#m-rule-call says that .m.rule.call is an underride rule, but that means that no notification will be sent in rooms configured for "mentions only".
it looks like this got fixed in https://github.com/matrix-org/synapse/commit/118c883429d1564f63ab37424a8e0bc602c10709, but accidentally (?) backed out in https://github.com/matrix-org/synapse/commit/ed83638668#diff-1c917f5a04539df1f69cb8e77054b016R184.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Matrix client-server specification section for .m.rule.call and compare it with the referenced Synapse commits, especially the rule change and its subsequent reversal. Confirm whether the specification's underride classification matches the intended notification behavior; done means the specification accurately documents the agreed rule classification.
Written by the indexing model from the issue text.
Assessment
- Domain
- documentation
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100