matrix-org / matrix-org/matrix-spec
Include heroes for invites/knocks to be able to display a room name
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 330
- Forks
- 150
- Avg merge
- 2h 21m
- Merged PRs (30d)
- 3
Description
**Suggestion**
As mentioned on https://github.com/matrix-org/matrix-spec-proposals/pull/4186#discussion_r1745991652 and https://github.com/matrix-org/matrix-spec-proposals/pull/4319#discussion_r2445511924,
> One weird corner with the current spec: If the room doesn't have a name set and the user is invited/knock to the room, we don't have any `heroes` to provide here. This is because `heroes` membership isn't included in the stripped state that the server receives when they are invited/knocked over federation.
>
> Related to https://github.com/matrix-org/matrix-spec/issues/380
>
> This was solved for partial-joins via [MSC3943](https://github.com/matrix-org/matrix-spec-proposals/pull/3943)
>
> *-- @MadLittleMods*
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked Matrix Spec Proposal discussions, MSC3943, and related issue #380 to understand how heroes are represented for partial joins and why invites or knocks differ. The issue does not name a repository file or test; completion would require an agreed protocol-specification change that defines heroes for these cases.
Written by the indexing model from the issue text.
Assessment
- Domain
- distributed-systems
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100