matrix-org / matrix-org/matrix-spec
How to handle event edits when excluding insecure devices
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 330
- Forks
- 150
- Avg merge
- 2h 21m
- Merged PRs (30d)
- 3
Description
**Link to problem area**:
https://github.com/matrix-org/matrix-spec-proposals/pull/4153
**Issue**
MSC4153 requires that
> Encrypted messages from non-cross-signed devices SHOULD be ignored
Now consider the following situation
* Alice sends an event from her cross-signed device, device A
* Alice sends an edit of that event from her non-cross-signed device, device B
What should Bob's client show? It seems like he should ignore the event edit (treating it the same way as [other invalid edits](https://spec.matrix.org/v1.17/client-server-api/#validity-of-replacement-events)), but this could do with being clarified, and we should make sure that the implementations in EW and EX do so.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with MSC4153 and the Client-Server API section on validity of replacement events, then trace how the proposed rule applies when the original and edit come from different device types. Done means the specification clearly defines the client-visible behavior and the handling is checked in EW and EX.
Written by the indexing model from the issue text.
Assessment
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100