matrix-org / matrix-org/matrix-spec
Reducing the impact of preflight requests
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 330
- Forks
- 150
- Avg merge
- 2h 21m
- Merged PRs (30d)
- 3
Description
For quick reference, a preflight request is required to be performed by a user agent implementing CORS when any of the following conditions are met:
- The method is something other than
GET,POSTorHEAD - A header other than
Accept,Accept-Language,Content-LanguageorContent-Typeis set manually Content-Typehas a value other thanapplication/x-www-form-urlencoded,multipart/form-data, ortext/plain
Since matrix uses Content-Type: application/json, all non-GET requests require a preflight, this means for example that sending any event to the server requires 2 requests, adding additional latency and a bit of overhead
Unfortunately there's no perfect solution to the problem, but here are some options:
Proxy requests through the same origin
This one shifts the work onto the client meaning nothing has to change spec wise, but has quite a few issues:
- Requires trusting the proxy to handle sensitive information (login details)
- Adds latency through indirection
- Adds another point of failure
- Not possible with static sites
Allow Content-Type: text/plain
Feels like a hack, but parsing plain text POST messages as if they were JSON would mean no preflight request. However this wouldn't help for the common path of sending messages to rooms which uses PUT
Improve preflight cacheability
Preflight requests can be optionally cached by the user agent indicated using the header Access-Control-Max-Age. However the cache is per URL not just the origin, meaning that any change in the path (which includes query parameters) warrants another preflight request
The large issue with this one is that it would require a breaking change to the API, with frequently changing parameters being placed in the JSON body or as HTTP headers
Websockets
Websockets have no such overhead once the connection is established, however whilst they do not require breaking API compatibility it's still a large spec addition
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the W3C CORS preflight and Access-Control-Max-Age references linked in the issue, then compare the proxy, content-type, cacheability, and WebSockets options. No repository file, test, or entry point is identified; the work is done only once the project agrees on a concrete, compatible API or specification change.
Written by the indexing model from the issue text.
Assessment
- Domain
- api, networking
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100