matrix-org / matrix-org/matrix-rust-sdk
`ClientBuildError` and `OpenStoreError` are missing conversion traits into `matrix_sdk::Error`
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 500
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 106
Description
There's no `From` and `From` for `matrix_sdk::Error`. This makes using e.g. `make_store_config` and `ClientBuilder` harder than necessary. Is there a reason for this?
@jplatte [mentions a discussion](https://matrix.to/#/!iYnZafYUoXkeVPOSQh:matrix.org/$f1SECzstdusUl62B4SCYqExc53uUDyoGl3rHbw0Ji0U?via=matrix.org&via=envs.net&via=gnome.org) may have happened at some point in the past, but there doesn't appear to be an issue for this so I'm opening one.
Contributor guide
Research direction
Search for ClientBuildError, OpenStoreError, and matrix_sdk::Error, then inspect existing error conversion implementations and the discussion linked in the issue. Confirm the intended conversions and add coverage alongside the relevant error tests; done means both conversions compile and the tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100