matrix-org / matrix-org/matrix-rust-sdk
unread counts: should an edit triggering a notification count as a notification?
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 500
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 106
Description
Right now, if we have both the original event and the edit event in a room, and both trigger notifications for some reasons (e.g. sent in a 1:1 room, include mentions), then they might set the number of unread notifications to 2, while arguably that should be only one, because the edit is an addition on top of the original event.
The question gets a bit larger: should notifications/mentions only be counted for events we deem interesting (that count in the unread messages count)? I don't think so, because this means that an edit that adds a mention would not trigger a mention (since edits aren't considered interesting), so we might need another set of rules/heuristics in this case.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not identify any files, tests, or entry points. First clarify whether edits should add to existing unread notification counts and how mentions on edits interact with interesting events; done means those notification-counting rules are agreed and documented well enough to implement.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100