matrix-org / matrix-org/matrix-rust-sdk
Correctly handle redacted state events
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 500
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 106
Description
We currently filter out redacted state events in some places and only handle unredacted ones. This is incorrect: Redacted state events still affect the room state.
Left to do after #627:
* [ ] Review remaining uses of `FooEvent::Original`
* [ ] Add fetching of events by ID to the state store, then apply incoming redactions to stored events
* [ ] State events
* [ ] Timeline events
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the remaining uses of FooEvent::Original and the state store entry points. Trace how events are fetched and how incoming redactions are applied, covering both state and timeline events. Done means redacted state events still affect room state and both listed event categories are handled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100