matrix-org / matrix-org/matrix-rust-sdk
timeline: get rid of `PinnedEventsRoom`
Open
Nobody has claimed this yet.
A-Timeline
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 500
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 106
Description
This trait is only implemented by Room, so we should consider putting a Room inside PinnedEventsLoader, which ought to lead to some other nice simplifications.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the PinnedEventsRoom trait, its Room implementation, and PinnedEventsLoader, then trace how the loader is constructed and used. Determine the smallest design that removes the trait while preserving pinned-event loading, and verify the existing Rust checks pass without regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100