matrix-org / matrix-org/matrix-rust-sdk

timeline: improve handling of edits

Open
#3,905 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
2.3k
Forks
500
Avg merge
1d 16h
Merged PRs (30d)
106

Description

- If an edit fails, find Some Way™ to reflect that in the timeline
- revert to the unedited version of the item?
- add a way to re-send the edit?
- If an edit succeeds, mark the item as such, and don't replace it with the previous unedited version (if it comes late from sync), see also https://github.com/element-hq/element-x-ios-rageshakes/issues/2126#issuecomment-2315708428
- but handle that another edit can come from another client through sync :eyes:
- #3948
- https://github.com/matrix-org/matrix-rust-sdk/issues/3941

Contributor guide

Open the contributing guide

Research direction

Start by reading the linked issues #3948 and matrix-rust-sdk #3941, plus the referenced Element X discussion, to understand the intended edit lifecycle. Trace the timeline edit and sync entry points identified there. Done means failed edits are represented or resendable, successful edits remain visible despite late sync data, and edits from other clients are handled.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.