matrix-org / matrix-org/matrix-rust-sdk

"Invalid" `m.direct` global account data causes issues when handling notifications.

Open
#3,770 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
2.3k
Forks
500
Avg merge
1d 16h
Merged PRs (30d)
106

Description

... I think? I saw a bunch of SSS requests, and looking at the EXA logs I found: `Failed to deserialize a global account data event: leading sigil is incorrect or missing at line 1 column 553 event_type="m.direct"`.

Indeed, in my `m.direct` I see an entry like `{"xxxx@jki.re": [...]}`, which is probably the thing that is causing issues.

I'm not sure exactly how much of a problem this (I have push disabled on EXA, so not even sure why its trying to handle notifications).

Contributor guide

Open the contributing guide

Research direction

Start by tracing handling of the `m.direct` global account data event and the notification path described in the issue, using the reported deserialization error and EXA logs as reproduction clues. Determine how malformed account data should be handled and verify that notification processing no longer fails or produces unexpected SSS requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.