matrix-org / matrix-org/matrix-rust-sdk
No to-device message ids on `m.room_key.withheld` messages
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 500
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 106
Description
Every generated to-device message should include an `org.matrix.msgid` field to help trace the messages through the system (at least, if the `message_ids` feature is enabled), but `matrix_sdk_crypto` appears to generate `m.room_key.withheld` messages without one.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the matrix_sdk_crypto code that generates m.room_key.withheld to-device messages, and compare it with the other generated to-device messages described in the issue. Verify the behavior with the message_ids feature enabled; done means withheld messages include an org.matrix.msgid field and the relevant coverage passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100