matrix-org / matrix-org/matrix-rust-sdk

widget: Check room IDs on read-event request

Open
#2,723 0 comments 0 reactions 0 assignees View on GitHub
A-Widgets enhancement
Dominant language
Rust
Stars
2.3k
Forks
500
Avg merge
1d 16h
Merged PRs (30d)
106

Description

Not needed by EC, but apparently it does send this field (for no good reason?). Roughly specced [here](https://github.com/matrix-org/matrix-spec-proposals/blob/travis/msc/widgets-send-receive-events/proposals/2762-widget-event-receiving.md#proposal-accessing-other-rooms). For now we can ignore it. It would make sense to

- make sure its absence is allowed in deserialization, not currently the case on the poc branch, and - raise an error if it's present but contains something other than just the current room ID (the only thing we should support until this is better specified and has a use case)

Contributor guide

Open the contributing guide

Research direction

Start with the widget read-event request deserialization and compare its behavior with the linked MSC 2762 proposal. Done means an absent room ID is accepted, the current room ID is accepted when present, and other room IDs are rejected with an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.