matrix-org / matrix-org/matrix-rust-sdk
Verification: `other_user_id`, `other_device_id`, etc not exposed once verification complete
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 500
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 106
Description
After verification, element-web shows a completion dialog along the lines of "You've successfully verified \: (\)!".
The `VerificationRequest` class thows away details like the device ID once the verification completes. We *could* fudge around it in the js-sdk, but it seems like a useful thing to expose to other applications.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the VerificationRequest class and trace how it handles completion, comparing the details available before and after verification. Determine how other applications can access the other user and device identifiers, then verify that the completion result exposes those details without requiring a js-sdk workaround.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100