matrix-org / matrix-org/matrix-rust-sdk
room::Common::is_encrypted fails for invited rooms if state is not considered synced
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 500
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 106
Description
In the case of checking is_encrypted for an invited room and the state isn't considered up-to-date (maybe this should never happen?), we do a get_state_events_for_key::v3::Request, but that always fails with 403 / forbidden for invited rooms.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at room::Common::is_encrypted and trace the get_state_events_for_key::v3::Request path when the room is invited and state is not considered synced. Reproduce the 403/forbidden response and determine the expected result for this case. Done means is_encrypted handles an invited room without failing on that request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100